Add missing properties for Vmss zone GA#2445
Conversation
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
Swagger to SDK encountered a Subprocess error: (Azure/azure-sdk-for-go)
Command: profileBuilder -s preview -name preview /bin/sh: 1: profileBuilder: not found |
anuchandy
added
the
WaitForARMFeedback
| }, | ||
| "zoneBalance": { | ||
| "type": "boolean", | ||
| "description": "Whether to force stictly even Virtual Machine distribution cross x-zones in case there is zone outage." |
There was a problem hiding this comment.
is x-zones some domain specific name?
There was a problem hiding this comment.
Somehow. "x-zones" or "zones redundant" or "cross zones" VMScaleSet.
|
@wangjun198389 you mentioned these are immutable properties, do you mean they are |
|
@anuchandy Those new properties can set only once when creating, cannot be changed later. |
|
@wangjun198389 sounds good, just one more question from my side - let's say we generate SDK from this PR |
|
@anuchandy old client can put(update) successfully. Server side treat it as no change for these two new properties. |
|
@wangjun198389 thanks. @ravbhatnagar looks good from SDK side, any comments from ARM side? |
|
new properties typically require a new api-version. but based on above comments, these properties are immutable. So its fine. Signing off! |
ravbhatnagar
added
ARMSignedOff
Automation for azure-sdk-for-pythonA PR has been created for you: |
Automation for azure-sdk-for-goSwagger to SDK encountered a Subprocess error: (azure-sdk-for-go)
Command: profileBuilder -s list -l ./profiles/2017-03-09/defintion.txt -name 2017-03-09 /bin/sh: 1: profileBuilder: not found |
6 participants
Updated compute spec to include missing properties zoneBalance and platformFaultDomainCount in VirtualMachineScaleSetProperties. We are using 2017-12-01 api version which is zone GA version. Both properties are immutable and optional. These properties are only for zone scenario, which is in public preview now.